Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump the windows group across 1 directory with 2 updates #345

Merged
merged 1 commit into from
Jan 13, 2025
Merged

build(deps): bump the windows group across 1 directory with 2 updates #345

merged 1 commit into from
Jan 13, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 13, 2025

Bumps the windows group with 2 updates in the / directory: winreg and windows.

Updates winreg from 0.52.0 to 0.55.0

Release notes

Sourced from winreg's releases.

0.55.0 (windows-sys)

  • Breaking change: Increate MSRV to 1.60
  • Breaking change: Upgrade windows-sys to version 0.59 (#77)

0.54.0 (windows-sys)

  • Breaking change: Migrate to the 2021 edition of Rust (MSRV 1.56)
  • Breaking change: Upgrade windows-sys to version 0.52 (closes #63, #70)

0.53.0 (windows-sys)

  • Don't stop deserialization of Any due to REG_NONE (pullrequest #67, fixes #66)
  • Implement (de)serialization of Option (#56)
  • Add RegKey methods for creating/opening subkeys with custom options (#65)
Changelog

Sourced from winreg's changelog.

0.55.0

  • Breaking change: Increate MSRV to 1.60
  • Breaking change: Upgrade windows-sys to version 0.59 (#77)

0.54.0

  • Breaking change: Migrate to the 2021 edition of Rust (MSRV 1.56)
  • Breaking change: Upgrade windows-sys to version 0.52 (closes #63, #70)

0.15.0, 0.53.0

  • Don't stop deserialization of Any due to REG_NONE (pullrequest #67, fixes #66)
  • Implement (de)serialization of Option (#56)
  • Add RegKey methods for creating/opening subkeys with custom options (#65)
Commits
  • 9243b23 Bump version to 0.55.0
  • f044074 Upgrade windows-sys to version 0.59 (and MSRV to 1.60)
  • 4574feb Bump version to 0.54.0
  • 105ca7a Upgrade windows-sys to version 0.52
  • 93aefdf Migrate to the 2021 edition of Rust
  • c9315d0 Clippy: remove unnecessary typecasts
  • e62111e Merge branch 'winapi'
  • 049035f Update the transaction example in the docs
  • 5baac5d CI: upgrade actions to the latest versions
  • cbaeb4e CI: check Cargo.toml formatting
  • Additional commits viewable in compare view

Updates windows from 0.58.0 to 0.59.0

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot
build(deps): bump the windows group across 1 directory with 2 updates
98c7647 
Bumps the windows group with 2 updates in the / directory: [winreg](https://github.com/gentoo90/winreg-rs) and [windows](https://github.com/microsoft/windows-rs).


Updates `winreg` from 0.52.0 to 0.55.0
- [Release notes](https://github.com/gentoo90/winreg-rs/releases)
- [Changelog](https://github.com/gentoo90/winreg-rs/blob/master/CHANGELOG.md)
- [Commits](gentoo90/winreg-rs@v0.52.0...v0.55.0)

Updates `windows` from 0.58.0 to 0.59.0
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](microsoft/windows-rs@0.58.0...0.59.0)

---
updated-dependencies:
- dependency-name: winreg
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: windows
- dependency-name: windows
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: windows
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 13, 2025
@CBenoit
Copy link
Member

CBenoit commented Jan 13, 2025 •
edited
Loading

@TheBestTvarynka Do you think you could look into this update of Windows dependencies, please?

  • It appears the dependencies are getting duplicated, and
  • We are using winreg when windows-registry is the official crate maintained by Microsoft

@TheBestTvarynka
Copy link
Collaborator

Of course. Let me handle it 😉

@TheBestTvarynka
Copy link
Collaborator

TheBestTvarynka commented Jan 13, 2025 •
edited
Loading

It appears the dependencies are getting duplicated

It's because the reqwest crate uses an older version of the windows-registry crate, which uses the older versions of windows-result, windows-strings, and other crates. The reqwest crate uses windows-registry = 0.2, whereas the 0.4 version exists.

We are using winreg when windows-registry is the official crate maintained by Microsoft

Is it a problem? I mean, should I refactor it now to use the windows-registry crate?

@CBenoit
Copy link
Member

CBenoit commented Jan 13, 2025

It appears the dependencies are getting duplicated

It's because the reqwest crate uses an older version of the windows-registry crate, which uses the older versions of windows-result, windows-strings, and other crates. The reqwest crate uses windows-registry = 0.2, whereas the 0.4 version exists.

Thank you! I’ll merge now and things will get right again when reqwest release an update 👍

We are using winreg when windows-registry is the official crate maintained by Microsoft

Is it a problem? I mean, should I refactor it now to use the windows-registry crate?

Not an immediate problem! We should consider upgrading at some point though

@CBenoit CBenoit merged commit a6b0f8c into master Jan 13, 2025
42 checks passed
@CBenoit CBenoit deleted the dependabot/cargo/windows-a13c926160 branch January 13, 2025 17:58
@TheBestTvarynka
Copy link
Collaborator

Not an immediate problem! We should consider upgrading at some point though

Let's create an issue about it. What do you think?

@CBenoit
Copy link
Member

CBenoit commented Jan 13, 2025 •
edited
Loading

Not an immediate problem! We should consider upgrading at some point though

Let's create an issue about it. What do you think?

Agreed. Issue created: #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit CBenoit approved these changes

Assignees

@CBenoit CBenoit

Labels
dependencies Pull requests that update a dependency file
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CBenoit @TheBestTvarynka